Rocco instead of docco#50
Merged
rstacruz merged 3 commits intorstacruz:masterfrom Jun 17, 2012
f1sherman:rocco-instead-of-docco
Merged
Rocco instead of docco#50rstacruz merged 3 commits intorstacruz:masterfrom f1sherman:rocco-instead-of-docco
rstacruz merged 3 commits intorstacruz:masterfrom
f1sherman:rocco-instead-of-docco
Conversation
Owner
|
Well, the stack uses Ruby already afterall so I suppose it's fitting. (Never thought anyone else would be touching this part so I didn't bother making it really good, do excuse the mess!) |
Owner
|
Looking back at the comments, I think I confused docco for rocco ("gem install docco" -- obviously wrong, heh). :-) |
Owner
|
Actually Rocco is broken right now: rtomayko/rocco#69 -- there's a drop-in replacement in the name of |
rstacruz
added a commit
that referenced
this pull request
Jun 17, 2012
rstacruz
added a commit
that referenced
this pull request
Jun 17, 2012
Contributor
Author
|
@rstacruz Good call, I did see the error from the issue you referenced but the site appeared to still build properly, though maybe I missed something. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the instructions to build the site included instructions to install docco with the command 'gem install docco'. This will not work because docco is an npm module. Since it takes a few more steps to install docco, it seemed easier to just use rocco (ruby port of docco), which can be installed with 'gem install rocco'. If you'd still prefer to use docco, I can submit another PR for that.
Also included a couple of very minor tweaks:
Thanks for the great library!